[css-typed-om] Rejig CSSResourceValue hierarchy. #9641
Conversation
Build ERROREDStarted: 2018-02-24 04:35:13 Failing Jobs
View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-934001
branch
from
20a6d28
to
4093922
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-934001
branch
from
4093922
to
e270f10
Compare
|
Weird, I can't seem to restart the build. I'll rebase the commit as a workaround. |
We implement the new CSSImageValue, which is an opaque object with no constructor. We also had to change the testsuite.js a bit to test it. Bug: 545318 Change-Id: I0ae719c5380e01ff9423e0ff0684afe547de1bb0 Reviewed-on: https://chromium-review.googlesource.com/934001 Commit-Queue: Darren Shen <[email protected]> Reviewed-by: nainar <[email protected]> Cr-Commit-Position: refs/heads/master@{#538730}
foolip
force-pushed
the
chromium-export-cl-934001
branch
from
e270f10
to
ca05a5e
Compare
|
I still can't make sense of this failure. I suspect a timeout due to the number of affected tests, but am not sure. Will try a PR with a subset of these changes to see if Travis still fails in the same way. |
|
Hmm, actually, the set of affected tests is pretty large, 94, probably because testhelper.js was modified. A lot of the tests pass on Chrome Dev, so I believe the explanation here is that because the browser is restarted between failing tests, it takes much longer in other browsers, and all have taken 40+ minutes and failed. Trying to run I'm going to blame #7660 for this as well, force merge, and accept the consequences if I'm wrong and this really breaks something. |
We implement the new CSSImageValue, which is an opaque object with no
constructor. We also had to change the testsuite.js a bit to test it.
Bug: 545318
Change-Id: I0ae719c5380e01ff9423e0ff0684afe547de1bb0
Reviewed-on: https://chromium-review.googlesource.com/934001
Commit-Queue: Darren Shen [email protected]
Reviewed-by: nainar [email protected]
Cr-Commit-Position: refs/heads/master@{#538730}